-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn when ConfigMap is missing or not parsable instead of erroring #4664
Conversation
Welcome @bryanhanner! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @bryanhanner. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @ElvinEfendi |
I signed the CLA today, so can you verify that you can see it on your side? Thanks! |
/ok-to-test |
/retest |
1 similar comment
/retest |
/check-cla |
Hi @ElvinEfendi this PR might have been delayed because I was missing the cncf-cla tag, but it's there now. Can you take another look? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, bryanhanner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4664 +/- ##
==========================================
+ Coverage 58.67% 58.69% +0.01%
==========================================
Files 88 88
Lines 6764 6762 -2
==========================================
Hits 3969 3969
+ Misses 2356 2355 -1
+ Partials 439 438 -1
Continue to review full report at Codecov.
|
What this PR does / why we need it:
This PR deescalates current errors to warnings when parsing and getting ConfigMaps in getStreamServices since there are a reasonable default it uses in both cases (the situation is recoverable). This also standardizes the repo a bit by making these logs more similar to https://github.com/kubernetes/ingress-nginx/blob/master/internal/ingress/controller/nginx.go#L547.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #There is no existing issue corresponding to this fix.
Special notes for your reviewer: