Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nginx variable service_port (nginx) #4500

Merged
merged 1 commit into from
Aug 31, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 28, 2019

What this PR does / why we need it:

Right now the generates nginx.conf contains set $service_port "{ 0 0}";

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@8740c1b). Click here to learn what that means.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4500   +/-   ##
=========================================
  Coverage          ?   59.16%           
=========================================
  Files             ?       89           
  Lines             ?     6779           
  Branches          ?        0           
=========================================
  Hits              ?     4011           
  Misses            ?     2336           
  Partials          ?      432
Impacted Files Coverage Δ
internal/ingress/types_equals.go 17.39% <0%> (ø)
internal/ingress/controller/template/template.go 78.63% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8740c1b...5d72d84. Read the comment docs.

aledbf referenced this pull request Aug 29, 2019
Co-authored-by: Charle Demers <charle.demers@gmail.com>
@aledbf aledbf merged commit c7d2444 into kubernetes:master Aug 31, 2019
@aledbf aledbf deleted the fix-serviceport branch September 1, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants