-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only support SSL dynamic mode #4356
Conversation
b7d1189
to
077dbae
Compare
/test pull-ingress-nginx-test |
Codecov Report
@@ Coverage Diff @@
## master #4356 +/- ##
=========================================
Coverage ? 60.61%
=========================================
Files ? 87
Lines ? 7018
Branches ? 0
=========================================
Hits ? 4254
Misses ? 2314
Partials ? 450
Continue to review full report at Codecov.
|
077dbae
to
9f1fd39
Compare
87101d9
to
a6148d2
Compare
7706f0c
to
008c2ec
Compare
@ElvinEfendi ready for another review |
There is a reload that should not be required
this happens a tls section is configured in the ingress or the secret is deleted |
8ca77dd
to
f248b34
Compare
/retest |
/test pull-ingress-nginx-e2e-1-15 |
0c42062
to
d2dd5d3
Compare
d2dd5d3
to
33d766b
Compare
/test pull-ingress-nginx-test |
33d766b
to
80bd481
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
This is actually a breaking change as it prevents existing instances from starting if they are configured with flag "--enable-dynamic-certificates". Result is: unknown flag: --enable-dynamic-certificates |
@oweise you don't need the flag anymore. Only dynamic certificates are supported Edit: the flag was removed in 0.31 9c6873a#diff-e64fced222d6b682ce87183241ee6022 |
What this PR does / why we need it:
Implements changes from KEP #4351
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: