Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable access log in stream section for configuration socket #4307

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 10, 2019

What this PR does / why we need it:

Removes [10/Jul/2019:17:37:18 +0000]TCP200000.000 from the output each time the controller updates the tcp/udp feature

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2019
@aledbf
Copy link
Member Author

aledbf commented Jul 10, 2019

/test pull-ingress-nginx-test

@codecov-io
Copy link

Codecov Report

Merging #4307 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4307      +/-   ##
==========================================
+ Coverage   58.28%   58.31%   +0.03%     
==========================================
  Files          87       87              
  Lines        6472     6472              
==========================================
+ Hits         3772     3774       +2     
+ Misses       2273     2272       -1     
+ Partials      427      426       -1
Impacted Files Coverage Δ
internal/ingress/metric/collectors/process.go 90.42% <0%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24373f...1e07cc6. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Jul 10, 2019

/test pull-ingress-nginx-e2e-1-12

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a1922e4 into kubernetes:master Jul 10, 2019
@aledbf aledbf deleted the remove-log branch July 10, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants