Set default for satisfy annotation to nothing #3822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: ingress-nginx recently added the
satisfy
annotation. This change caused the nginx.confsatisfy
directive to always be set, even if the annotation is not set. This presents a problem as it breaks any ingress definition that setssatisfy
using aserver-snippet
orconfiguration-snippet
, because then there are twosatisfy
directives at once. This PR prevents thesatisfy
directive from being applied unless the annotation is actually present and valid.This should not change the behaviour of ingress-nginx as leaving out the
satisfy
directive is the same as settingsatisfy all;
, which is the previous default value.cc: @ElvinEfendi