-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use struct to pack Ingress and its annotations #3437
Conversation
/assign @ElvinEfendi |
4440b0c
to
10edfb1
Compare
I'll have a look to CI / Tests |
10edfb1
to
12766cd
Compare
Tests should be fine |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi, wayt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR pack
extensions.Ingress
andannotations.Ingress
into one struct.The purpose of this is to reduce the possible race condition we have with annotations.
See #3411
Which issue this PR fixes
fixes #3411