Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure load balance e2e tests and update round robin test #3407

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Restructure load balance e2e tests and update round robin test #3407

merged 1 commit into from
Nov 12, 2018

Conversation

zrdaley
Copy link
Contributor

@zrdaley zrdaley commented Nov 12, 2018

What this PR does / why we need it:

  • Moves load balancer e2e tests to new folder with a file per load balance algorithm (currently only round_robin.go exists)
  • Updates round robin test to use only one nginx worker to ensure equal distribution of requests

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 12, 2018
@zrdaley zrdaley mentioned this pull request Nov 12, 2018
Merged
@ElvinEfendi
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi, zrdaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit 01a343c into kubernetes:master Nov 12, 2018
@zrdaley zrdaley deleted the rr-e2e branch November 12, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoineco antoineco Awaiting requested review from antoineco

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees

@ElvinEfendi ElvinEfendi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zrdaley @ElvinEfendi @k8s-ci-robot