Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPT: annotation enhancement for resty-lua-waf #3187

Merged

Conversation

DesmondH0
Copy link
Contributor

@DesmondH0 DesmondH0 commented Oct 5, 2018

Dear community,

feature

  • nginx.ingress.kubernetes.io/lua-resty-waf-allow-unknown-content-types
    • for allowing the unknown content
  • nginx.ingress.kubernetes.io/lua-resty-waf-score-threshold
    • for override the score threshold for lua waf
  • nginx.ingress.kubernetes.io/lua-resty-waf-process-multipart-body
    • for disabling resty lua to check the multipart contents

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 5, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2018
@DesmondH0
Copy link
Contributor Author

I signed it

@aledbf
Copy link
Member

aledbf commented Oct 7, 2018

@DesmondHoLLM please rebase to pass CI

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 7, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2018
@DesmondH0
Copy link
Contributor Author

@aledbf thanks for replying
had updated the testing and CI is passed now

P.S. the cla is marked as failed again after rebase 🤔

@aledbf aledbf closed this Oct 16, 2018
@aledbf aledbf reopened this Oct 16, 2018
@aledbf
Copy link
Member

aledbf commented Oct 16, 2018

/check-cla

@aledbf
Copy link
Member

aledbf commented Oct 16, 2018

DesmondHoLLM authorized, but 1 other problem

@DesmondHoLLM please rebase and squash the commits. The problem should go away after that.

@DesmondH0 DesmondH0 force-pushed the feature/annotations-resty-lua branch from 3409493 to 54d4fe3 Compare October 17, 2018 10:06
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 17, 2018
@DesmondH0 DesmondH0 force-pushed the feature/annotations-resty-lua branch from 54d4fe3 to 848b795 Compare October 17, 2018 10:12
@DesmondH0
Copy link
Contributor Author

@aledbf thanks for reminding
squashed the commits and working now

@DesmondH0 DesmondH0 force-pushed the feature/annotations-resty-lua branch 2 times, most recently from aa5e438 to c9ad9c0 Compare October 19, 2018 02:42
@DesmondH0
Copy link
Contributor Author

Dear all,

added another annotation for work around of this issue:
p0pr0ck5/lua-resty-waf#166

/assign @ElvinEfendi

@DesmondH0 DesmondH0 force-pushed the feature/annotations-resty-lua branch from b4125e6 to deb7e21 Compare October 20, 2018 04:10
@DesmondH0 DesmondH0 force-pushed the feature/annotations-resty-lua branch from c428b64 to bab521e Compare October 20, 2018 04:47
@DesmondH0
Copy link
Contributor Author

Hi @ElvinEfendi, updated the pr
but CI failed in e2e after rebase (seems related to others stuff)

could you please advise, thanks

@DesmondH0 DesmondH0 force-pushed the feature/annotations-resty-lua branch 2 times, most recently from 94e69b4 to f50aa5c Compare October 25, 2018 03:12
@DesmondH0 DesmondH0 force-pushed the feature/annotations-resty-lua branch from 915dd5c to bf03046 Compare October 25, 2018 06:17
@ElvinEfendi
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DesmondHoLLM, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2018
@ElvinEfendi
Copy link
Member

@DesmondHoLLM thanks!

@k8s-ci-robot k8s-ci-robot merged commit 063f652 into kubernetes:master Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants