[404-server] Removes 404 server #3156
Conversation
k8s-ci-robot
added
cncf-cla: yes
aledbf
added
the
do-not-merge/hold
|
@aledbf what's blocking this PR? |
|
@ElvinEfendi the code needs to be merged in ingress-gce before the removal |
|
Closing. PR kubernetes/ingress-gce#503 is merged |
|
This says its no longer needed. but not seeing anything about why/how that is? Is there some more info somewhere? |
The default backend flag is not mandatory anymore since #3126 This means by default nginx handles the 404 default backend request. |
|
Ah. ok. thanks. |
|
@aledbf I think this was supposed to be merged, not closed 😄 |
|
@jonpulsifer you are right 😅 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jonpulsifer If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jonpulsifer can you rebase to be able to merge this? |
This commit removes the 404-server because it is moving to the kubernetes/ingress-gce repoistory Ref kubernetes/ingress-gce#498 Signed-off-by: Jonathan Pulsifer <jonathan.pulsifer@shopify.com>
This commit adds a README.md file with the new location of the 404-server Signed-off-by: Jonathan Pulsifer <jonathan.pulsifer@shopify.com>
|
rebased! |
|
@jonpulsifer thanks! |
It's not needed since nginx 0.20.0. See the following pull-requests for context: * kubernetes/ingress-nginx#3126 * kubernetes/ingress-nginx#3156
It's not needed since nginx 0.20.0. See the following pull-requests for context: * kubernetes/ingress-nginx#3126 * kubernetes/ingress-nginx#3156
Removes the 404-server because it's going to live in the kubernetes/ingress-gce repository ref kubernetes/ingress-gce#503 and kubernetes/ingress-gce#498