Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Precisations on the usage of the InfluxDB module #2928

Merged

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Aug 12, 2018

Signed-off-by: Lorenzo Fontana lo@linux.com

What this PR does / why we need it:
Noted that there was some confusion on how to use the Nginx annotation related to the fact that there's no Domain name resolution, made that clear in the docs.
Also more clearly explained that this annotation can be used to push data to other backend other than influx like, kafka, prometetheus and more by using it in tandem with Telegraf.

Signed-off-by: Lorenzo Fontana <lo@linux.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 12, 2018
@fntlnz
Copy link
Contributor Author

fntlnz commented Aug 12, 2018

/assign @ElvinEfendi

@aledbf
Copy link
Member

aledbf commented Aug 12, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, fntlnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit e7b8c2e into kubernetes:master Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants