Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add help for tls prerequisite for ingress.yaml #2806

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

yogin16
Copy link
Contributor

@yogin16 yogin16 commented Jul 18, 2018

What this PR does / why we need it: conveys the prerequisite that to use grpc backend we need to have tls setup

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 18, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 18, 2018
@yogin16
Copy link
Contributor Author

yogin16 commented Jul 18, 2018

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 18, 2018
@antoineco
Copy link
Contributor

conveys the prerequisite that to use grpc backend we need to have tls setup

Which is true, GRPC uses http2 and ingress-nginx requires TLS to be enabled to use http2.

@codecov-io
Copy link

Codecov Report

Merging #2806 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2806      +/-   ##
==========================================
+ Coverage   47.33%   47.34%   +0.01%     
==========================================
  Files          75       75              
  Lines        5413     5413              
==========================================
+ Hits         2562     2563       +1     
+ Misses       2527     2525       -2     
- Partials      324      325       +1
Impacted Files Coverage Δ
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c289b...ef69df6. Read the comment docs.

@yogin16
Copy link
Contributor Author

yogin16 commented Jul 19, 2018

/assign @antoineco

@aledbf
Copy link
Member

aledbf commented Jul 19, 2018

@yogin16 please don't assign PRs manually

@yogin16
Copy link
Contributor Author

yogin16 commented Jul 19, 2018

sorry, about that. (first pr)
confusion because the bot said

please assign additional approvers

I now get that the checks needs to say ready before that.

@antoineco
Copy link
Contributor

Indeed, besides what do you think about my comment above?

@aledbf
Copy link
Member

aledbf commented Aug 23, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2018
@aledbf
Copy link
Member

aledbf commented Aug 23, 2018

@yogin16 thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, yogin16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2018
@k8s-ci-robot k8s-ci-robot merged commit b214282 into kubernetes:master Aug 23, 2018
@yogin16 yogin16 deleted the patch-1 branch August 23, 2018 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants