Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prometheus labels #2790

Merged
merged 1 commit into from
Jul 16, 2018
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 16, 2018

Which issue this PR fixes : fixes #2787

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 16, 2018
@antoineco
Copy link
Contributor

/lgtm
sed for the win

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #2790 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2790      +/-   ##
==========================================
+ Coverage   47.57%   47.58%   +0.01%     
==========================================
  Files          75       75              
  Lines        5413     5413              
==========================================
+ Hits         2575     2576       +1     
+ Misses       2511     2509       -2     
- Partials      327      328       +1
Impacted Files Coverage Δ
internal/ingress/metric/collectors/socket.go 79.72% <100%> (ø) ⬆️
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2400e...4c1e501. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 2486ad9 into kubernetes:master Jul 16, 2018
@aledbf aledbf deleted the update-labels branch July 16, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
4 participants