Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nginx influxdb module to f8732268d44aea706ecf8d9c6036e9b6dacc99b2 #2603

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

fntlnz
Copy link
Contributor

@fntlnz fntlnz commented Jun 5, 2018

There have been important updated in the module since when I contributed the annotations to the ingress so wanted to make sure that those are in before the ingress controller is released.
See: influxdata/nginx-influxdb-module#7
Signed-off-by: Lorenzo Fontana lo@linux.com

Signed-off-by: Lorenzo Fontana <lo@linux.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2018
@fntlnz
Copy link
Contributor Author

fntlnz commented Jun 5, 2018

/assign @aledbf

@codecov-io
Copy link

Codecov Report

Merging #2603 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2603   +/-   ##
=======================================
  Coverage   40.68%   40.68%           
=======================================
  Files          75       75           
  Lines        5108     5108           
=======================================
  Hits         2078     2078           
  Misses       2751     2751           
  Partials      279      279

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eca3b7...2c6b302. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jun 5, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, fntlnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3b0d225 into kubernetes:master Jun 5, 2018
@fntlnz fntlnz deleted the influx-module-update-0 branch June 5, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants