-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crossplat fixes #2602
Crossplat fixes #2602
Conversation
/assign @aledbf |
@toolboc please squash the commits and we are ready to go |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, toolboc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2602 +/- ##
=======================================
Coverage 40.68% 40.68%
=======================================
Files 75 75
Lines 5108 5108
=======================================
Hits 2078 2078
Misses 2751 2751
Partials 279 279 Continue to review full report at Codecov.
|
👍 |
What this PR does / why we need it:
This PR contains changes to the nginx image that are required for proper cross-platform referencing of lua libraries.
Explanation:
This is a two-part PR to address issues in non x86-x64 builds with regard to lua library references that was uncovered during investigation of Issue #2547. This PR contains changes to the base nginx image which are required to merge in order to verify the CI build before a subsequent change to nginx.tmpl will occur in PR #2597 . Acceptance of this PR will require a republish of the nginx base image for all platforms to enable acceptance of #2597.
Which issue this PR fixes
Addresses #2547