Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for bind-address #2523

Merged
merged 1 commit into from
May 16, 2018
Merged

Add tests for bind-address #2523

merged 1 commit into from
May 16, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 16, 2018

Which issue this PR fixes : fixes #2520

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2018
antoineco
antoineco reviewed May 16, 2018
View reviewed changes
test/data/config.json Outdated
"cfg": {
"disable-ipv6": false,
"bind-address-ipv4": [ "1.1.1.1" , "2.2.2.2"],
"bind-address-ipv6": [ "[2001:db8:a0b:12f0::1]" ,"[3731:54:65fe:2::a7,33:33:33::33::33]" ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to test an array containing multiple valid IP addresses as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codecov-io
Copy link

Codecov Report

Merging #2523 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2523   +/-   ##
=======================================
  Coverage   41.66%   41.66%           
=======================================
  Files          74       74           
  Lines        5282     5282           
=======================================
  Hits         2201     2201           
  Misses       2783     2783           
  Partials      298      298

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df61bd7...a085808. Read the comment docs.

@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit af415d5 into kubernetes:master May 16, 2018
@aledbf aledbf deleted the fix-bind-ip branch May 17, 2018 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoineco antoineco antoineco left review comments

Assignees

@ElvinEfendi ElvinEfendi

@antoineco antoineco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BindAddress is converted to bytes
5 participants
@aledbf @codecov-io @antoineco @k8s-ci-robot @ElvinEfendi