Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TrimLeft for TrimPrefix on the from-to-www redirect #2477

Merged
merged 1 commit into from
May 8, 2018

Conversation

snelis
Copy link
Contributor

@snelis snelis commented May 7, 2018

What this PR does / why we need it:
This is a fix for the redirect from to www functionality in combination with a domain that starts with a w
Right now it uses a TrimLeft which means www.we-foo-bar.com becomes e-foo-bar.com.
I think a better solution would be to use TrimPrefix

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2018
@codecov-io
Copy link

Codecov Report

Merging #2477 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2477      +/-   ##
==========================================
- Coverage   41.67%   41.61%   -0.06%     
==========================================
  Files          74       74              
  Lines        5291     5291              
==========================================
- Hits         2205     2202       -3     
- Misses       2790     2792       +2     
- Partials      296      297       +1
Impacted Files Coverage Δ
internal/ingress/controller/nginx.go 11.26% <0%> (ø) ⬆️
cmd/nginx/main.go 21.37% <0%> (-2.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6cb9fb...cfc7cbc. Read the comment docs.

@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2018
@aledbf
Copy link
Member

aledbf commented May 8, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco, snelis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2018
@aledbf
Copy link
Member

aledbf commented May 8, 2018

@snelis thanks!

@k8s-ci-robot k8s-ci-robot merged commit a30b96b into kubernetes:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants