-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nginx-opentracing to 0.3.0 #2411
Conversation
This version includes a new `http.host` header to make searching by vhost in zipkin or jaeger more trivial.
/assign @bprashanth |
/assign @aledbf |
/retest |
The error is related to golang/lint#397 (there are ongoing hosting issues) |
@SEJeff please rebase from master. The golint issue is fixed |
Codecov Report
@@ Coverage Diff @@
## master #2411 +/- ##
=======================================
Coverage 40.91% 40.91%
=======================================
Files 74 74
Lines 5252 5252
=======================================
Hits 2149 2149
Misses 2809 2809
Partials 294 294 Continue to review full report at Codecov.
|
/approve |
/lgtm |
@SEJeff thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, SEJeff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Updates nginx-opentracing to 0.3.0
Special notes for your reviewer:
This version includes opentracing-contrib/nginx-opentracing#32 to add a
http.host
tag. This makes it easier to search in tracing backends which lack wildcard support such as zipkin or jaeger.