disable lua for arch s390x and ppc64le #2333
Conversation
k8s-ci-robot
added
cncf-cla: yes
oilbeater
force-pushed
the
fix/disable-lua
branch
from
ed61dfc
to
58c8a65
Compare
Codecov Report
@@ Coverage Diff @@
## master #2333 +/- ##
==========================================
+ Coverage 37.8% 37.81% +<.01%
==========================================
Files 72 72
Lines 5140 5144 +4
==========================================
+ Hits 1943 1945 +2
- Misses 2900 2902 +2
Partials 297 297
Continue to review full report at Codecov.
|
|
/assign @aledbf @ElvinEfendi |
|
@oilbeater: GitHub didn't allow me to assign the following users: ElvinEfendi. Note that only kubernetes members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cmd/nginx/flags.go
Outdated
| @@ -201,6 +201,16 @@ func parseFlags() (bool, *controller.Configuration, error) { | |||
| glog.Warningf("Disabling dynamic configuration feature (LuaJIT is not available in s390x and ppc64le)") | |||
| } | |||
|
|
|||
| // LuaJIT is not available on arch s390x and ppc64le | |||
There was a problem hiding this comment.
this makes the logic above obsolete now, right? can you delete it?
There was a problem hiding this comment.
oh right, i will remove it
LuaJIT is not available for s390x and ppc64le, disable the lua part in nginx.tmpl on these platform.
oilbeater
force-pushed
the
fix/disable-lua
branch
from
58c8a65
to
1be1f65
Compare
|
/approve |
|
@oilbeater thanks! |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, oilbeater The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@aledbf @oilbeater can you please help merge this to 0.12.0 as well? |
We cannot do that. Tomorrow we are going to release 0.13 where the fix will be included. |
What this PR does / why we need it:
LuaJIT is not available for s390x and ppc64le, disable the lua part in nginx.tmpl on these platform.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #2295Special notes for your reviewer: