do not hardcode keepalive for upstream_balancer #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
ElvinEfendi
force-pushed
the
consider-keepalive-config-for-dynamic-upstream
branch
from
8860d42
to
b212ae5
Compare
|
/approve |
|
@ElvinEfendi thanks! |
Codecov Report
@@ Coverage Diff @@
## master #2227 +/- ##
==========================================
- Coverage 37.12% 36.98% -0.15%
==========================================
Files 70 70
Lines 4978 4978
==========================================
- Hits 1848 1841 -7
- Misses 2851 2857 +6
- Partials 279 280 +1
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The PR makes sure we don't hard code
keepalivesetting when dynamic configuration is enabled.Ideally this should be configurable per ingress, but having a generally configurable option is also better than hardcoding its value.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: