Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix grammer mistake #2200

Merged
merged 1 commit into from
Mar 16, 2018
Merged

fix grammer mistake #2200

merged 1 commit into from
Mar 16, 2018

Conversation

jonyhy96
Copy link

@jonyhy96 jonyhy96 commented Mar 16, 2018 •
edited
Loading

fix grammar mistake

None

What this PR does / why we need it:
google is a role model company and shoud not have grammar mistake

Special notes for your reviewer:
google is a role model company and shoud not have grammar mistake

fix grammer mistake
a8e8127 
fix grammer mistake
```release-note
None
```
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2018
@jonyhy96
Copy link
Author

/assign @aledbf

@aledbf
Copy link
Member

aledbf commented Mar 16, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, jonyhy96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member

aledbf commented Mar 16, 2018

@jonyhy96 thanks!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2018
@aledbf aledbf merged commit d27a132 into kubernetes:master Mar 16, 2018
@aledbf
Copy link
Member

aledbf commented Mar 16, 2018

@jonyhy96 just in case nobody from google wrote that code. It was my fault. Apologies for that.

@jonyhy96
Copy link
Author

@aledbf
thank you for your apply and thanks for your great work
i dreamed that one day i can be a great contributor just like you
wish you have a good have a good weekend.

ElvinEfendi pushed a commit to Shopify/ingress that referenced this pull request Mar 16, 2018
@ElvinEfendi
fix grammer mistake (kubernetes#2200)
3b1e15a 
fix grammer mistake
```release-note
None
```
@jpiper
Copy link

jpiper commented Mar 17, 2018

I can't tell if it's a pun that "grammar" is spelled incorrectly :p

@jonyhy96
Copy link
Author

@jpiper
Thank you for your correct and wish you have a good day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonyhy96 @aledbf @k8s-ci-robot @jpiper