Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to enable/disable proxy buffering #1998

Merged
merged 2 commits into from
Jan 29, 2018

Conversation

aramase
Copy link
Member

@aramase aramase commented Jan 29, 2018

This PR adds configmap and annotation option proxy-buffering to enable/disable proxy-buffering.

It is set to off by default, which corresponds to the current ingress behavior.

fixes #1972

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 29, 2018
@aramase aramase changed the title Proxy buffering Add support to enable/disable proxy buffering Jan 29, 2018
@aledbf aledbf self-assigned this Jan 29, 2018
@aledbf
Copy link
Member

aledbf commented Jan 29, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, aramase

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 39.55% when pulling 0c94696 on aramase:proxy-buffering into 8688953 on kubernetes:master.

@aledbf aledbf merged commit b020686 into kubernetes:master Jan 29, 2018
@aledbf
Copy link
Member

aledbf commented Jan 29, 2018

@aramase thanks!

@aramase aramase deleted the proxy-buffering branch January 30, 2018 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Please make it possible to enable proxy_buffering
5 participants