Add X-Forwarded-Prefix on rewrites #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@maxlaverse thanks! |
|
HI @maxlaverse ! I am trying to figure how to set this annotation on. Should it look like: ? Or there is a different syntax? |
|
@metaflow yes, it's a boolean but you've got the annotation wrong ( |
|
Thank you @pieterlange, it works! Side question: what are the translation rules from |
This was referenced Jun 15, 2018
spencergibb
pushed a commit
to spring-cloud/spring-cloud-gateway
that referenced
this pull request
Aug 14, 2018
If the path of the url that the gw is routing to is a subset of the url that it is routing from then the difference is the prefix. Also applies if the path of the url being routed to is empty and the routed-from url path is non-empty. Included quite a few null checks as it should allow for the various different route definition styles and types of request. I've been [using this](https://github.com/ryandawsonuk/activiti-cloud-gateway/tree/develop/src/main/java/org/springframework/cloud/gateway/filter/headers) in k8s by overriding the class and found the null checks to be necessary. Was thinking it could be disabled by default as that's how it is for [nginx ingress](kubernetes/ingress-nginx#1805) but I haven't thought of any specific reason not to enable by default. fixes gh-314
go2max
pushed a commit
to go2max/spring-microservice-api
that referenced
this pull request
May 15, 2021
If the path of the url that the gw is routing to is a subset of the url that it is routing from then the difference is the prefix. Also applies if the path of the url being routed to is empty and the routed-from url path is non-empty. Included quite a few null checks as it should allow for the various different route definition styles and types of request. I've been [using this](https://github.com/ryandawsonuk/activiti-cloud-gateway/tree/develop/src/main/java/org/springframework/cloud/gateway/filter/headers) in k8s by overriding the class and found the null checks to be necessary. Was thinking it could be disabled by default as that's how it is for [nginx ingress](kubernetes/ingress-nginx#1805) but I haven't thought of any specific reason not to enable by default. fixes gh-314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add an annotation
x-forwarded-prefixthat activate the addition of aX-Forwarded-Prefixto the request sent to the upstream. This prefix has the value of the Nginx location that matched the rewrite.Which issue this PR fixes
fixes #1774