Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom default backend must use annotations if present #1768

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Custom default backend must use annotations if present #1768

merged 1 commit into from
Nov 30, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 29, 2017 •
edited
Loading

fixes #1761

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 29, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 37.178% when pulling 14a9e66 on aledbf:fix-default-backend into 37a230c on kubernetes:master.

@aledbf aledbf merged commit 2e3c7e2 into kubernetes:master Nov 30, 2017
@aledbf aledbf deleted the fix-default-backend branch November 30, 2017 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingress annotations are ignored when single service ingress is used
4 participants
@aledbf @k8s-reviewable @coveralls @k8s-ci-robot