Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --report-node-internal-ip-address describe to cli-arguments.md #1713

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

iamgd67
Copy link
Contributor

@iamgd67 iamgd67 commented Nov 16, 2017

What this PR does / why we need it: a document fix, add --report-node-internal-ip-address config describe as added in nginx-0.9.0-beta.16. Without this describetion, users may got very confused when seeing empty ingress endpoints when node got only internal ip address.

Special notes for your reviewer: related to pull request of #1503

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 16, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 36.167% when pulling 5f1655d on iamgd67:nginx-0.9.0-beta.16-dockfix into cea1042 on kubernetes:master.

@iamgd67
Copy link
Contributor Author

iamgd67 commented Nov 16, 2017

check cla??

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 16, 2017
@aledbf
Copy link
Member

aledbf commented Nov 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2017
@aledbf
Copy link
Member

aledbf commented Nov 16, 2017

@iamgd67 thanks!

@aledbf aledbf merged commit e4c8488 into kubernetes:master Nov 16, 2017
@iamgd67 iamgd67 deleted the nginx-0.9.0-beta.16-dockfix branch November 17, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants