Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brotli support #1627

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Add brotli support #1627

merged 1 commit into from
Nov 1, 2017

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Oct 30, 2017

What this PR does / why we need it: This PR adds support for Brotli compression.

Brotli is an algorithm designed by Google that have up to 25% of efficience when compared to gzip.

There's more info here and here

The following tasks need to be executed:

  • Add Brotli module to NGINX
  • Add ConfigMap annotation to enable brotli, and also the selected mime types that are going to be supported

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2017
@rikatz rikatz changed the title WIP: Add brotli support Add brotli support Nov 1, 2017
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2017
@rikatz
Copy link
Contributor Author

rikatz commented Nov 1, 2017

Tested. If both Brotli and GZIP are enabled, brotli will be firstly used as defined per user's browser.

If the backend uses GZIP, GZIP will be used then.

@aledbf
Copy link
Member

aledbf commented Nov 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2017
@aledbf
Copy link
Member

aledbf commented Nov 1, 2017

@rikatz thanks!

@aledbf aledbf merged commit dc3225e into kubernetes:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants