Chart: Implement controller.admissionWebhooks.service.servicePort.

[ralgozino]

What this PR does / why we need it:

While the chart values.yaml provides a controller.admissionWebhooks.service.servicePort option, its value was being ignored by the chart template.

This PR changes the template to use the value for the admission webhook service port in the Service definition and in the corresponding ValidatingWebhookConfiguration instead of ignoring it.

The PR also adds some Helm unit tests for this value.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

• Manually tested that the change works as expected (service uses the custom port, webhook configuration point to the right port).
• Launched make kind-e2e-chart-tests locally (mac M1): all tests passed
• Launched helm unittest charts/ingress-nginx -d locally (mac M1): all tests passed.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ralgozino / name: Ramiro Algozino (708df99)

[k8s-ci-robot]

Welcome @ralgozino!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ralgozino. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	708df99
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66d8b981ed54fb0009f6b29d

[Gacko]

/triage accepted
/kind bug
/priority backlog
/hold

Thanks for your contribution! I'll review it later, hopefully! 🙂

[ralgozino]

thank you @Gacko

This is my first contribution to the project, please let me know if I missed anything and I'll happily fix it :-)

Have a nice day!

[Gacko]

/ok-to-test
/lgtm
/unhold

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, ralgozino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [Gacko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Gacko]

Ciao!

Since you enabled the option for maintainers to edit your fork, I implemented a few improvements, mainly around the tests, and rebased your branch. Apart from that, your proposal looks good and is ready to be merged.

Mille grazie e buona serata!

[Gacko]

/cherry-pick release-1.10

[Gacko]

/cherry-pick release-1.11

[k8s-infra-cherrypick-robot]

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@Gacko: new pull request created: #11933

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@Gacko: new pull request created: #11934

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ralgozino]

Ciao!

Since you enabled the option for maintainers to edit your fork, I implemented a few improvements, mainly around the tests, and rebased your branch. Apart from that, your proposal looks good and is ready to be merged.

Mille grazie e buona serata!

Thank you for the feedback. I saw your changes, they make a lot of sense.

Buona giornata and see you in the next PR :-)