Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud Build: Some chores. #11757

Merged
merged 13 commits into from
Aug 11, 2024
Merged

Cloud Build: Some chores. #11757

merged 13 commits into from
Aug 11, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link
Contributor

This is an automated cherry-pick of #11633

/assign Gacko

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 11, 2024
Merged
10 tasks
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2024
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2024
Gacko
Gacko approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@Gacko Gacko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle Cloud Build: Some chores.
/triage accepted
/kind cleanup
/priority backlog
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2024
@Gacko Gacko changed the title [release-1.11] Cloud Build: Some chores. Cloud Build: Some chores. Aug 11, 2024
@Gacko Gacko merged commit 1330c06 into kubernetes:release-1.11 Aug 11, 2024
71 of 72 checks passed
krunalhinguu pushed a commit to krunalhinguu/ingress-nginx that referenced this pull request Aug 20, 2024
@k8s-infra-cherrypick-robot @Gacko @krunalhinguu
Cloud Build: Some chores. (kubernetes#11757)
311d807 
* Cloud Build: Remove comment.

* Cloud Build: Add newlines at EOF.

* Cloud Build: Align comment.

* Cloud Build: Remove trailing slash.

* Cloud Build: Remove quotes.

* Cloud Build: Align indentation.

* Cloud Build: Improve quotes.

* Cloud Build: Put arguments in one line.

* Cloud Build: Bump image.

* Cloud Build: Reorder entrypoint.

* Cloud Build: Adjust timeouts.

* Cloud Build: Remove useless files.

* Cloud Build: Remove `substitution_option`.

---------

Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gacko Gacko Gacko approved these changes

@invidian invidian Awaiting requested review from invidian

@puerco puerco Awaiting requested review from puerco

Assignees

@Gacko Gacko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @Gacko