Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert module upgrade #11594

Merged
merged 1 commit into from
Jul 10, 2024
Merged

revert module upgrade #11594

merged 1 commit into from
Jul 10, 2024

Conversation

strongjz
Copy link
Member

fixes #11588

@strongjz
revert module upgrade
5259f67 
Signed-off-by: James Strong <strong.james.e@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 10, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 10, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 5259f67
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/668f03b17d566300085d1e2e

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@rikatz
Copy link
Contributor

rikatz commented Jul 10, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 90fa3b9 into kubernetes:main Jul 10, 2024
58 checks passed
@strongjz
Copy link
Member Author

/cherry-pick release-1.10
/cherry-pick release-1.11

@k8s-infra-cherrypick-robot
Copy link
Contributor

@strongjz: new pull request created: #11595

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 11, 2024
Merged
@Gacko
Copy link
Member

Gacko commented Jul 11, 2024

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #11597

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 11, 2024
Merged
@saiharshitach
Copy link

saiharshitach commented Jul 16, 2024 •
edited
Loading

so since this is merged can we use a specific image of controller v1.11.0?or a direct image tag v1.11.0 will fix the issue ? or Do we wait for the patch to come in ?

@strongjz / @Gacko

@strongjz strongjz mentioned this pull request Jul 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gacko Gacko Awaiting requested review from Gacko

@puerco puerco Awaiting requested review from puerco

Assignees

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingress NGINX v1.10.2 & v1.11.0 throw core dumps
6 participants
@strongjz @k8s-ci-robot @rikatz @k8s-infra-cherrypick-robot @Gacko @saiharshitach