Allow specifying the name of the header for forwarding client certificates #10359

tuxillo · 2023-09-01T18:29:28Z

What this PR does / why we need it:

Try to address #3511 .

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
CVE Report (Scanner found CVE and adding report)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Just did a make build:)

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I've read the CONTRIBUTION guide
I have added unit and/or e2e tests to cover my changes.
All new and existing tests passed.

…cates

linux-foundation-easycla · 2023-09-01T18:29:34Z

The committers listed above are authorized under a signed CLA.

✅ login: tuxillo / name: Antonio Huete Jimenez (affd873)

netlify · 2023-09-01T18:29:34Z

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	`affd873`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/64f22d8a6b6bf700083fa096

k8s-ci-robot · 2023-09-01T18:29:36Z

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-09-01T18:29:36Z

Welcome @tuxillo!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-09-01T18:29:37Z

Hi @tuxillo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-09-01T18:29:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tuxillo
Once this PR has been reviewed and has the lgtm label, please assign tao12345666333 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rikatz · 2023-09-05T21:52:24Z

internal/ingress/annotations/authtls/main.go

@@ -80,6 +81,12 @@ var authTLSAnnotations = parser.Annotation{
 			Risk:          parser.AnnotationRiskLow,
 			Documentation: `This annotation defines if the received certificates should be passed or not to the upstream server in the header "ssl-client-cert"`,
 		},
+		annotationAuthTLSPassCertToUpstreamHeader: {
+			Validator:     parser.ValidateNull,


Please don't ignore the validation, as you are passing a string, you should add what is the possible value

Yeah, I thought so too. Is there any existing example I can follow?

rikatz · 2023-09-05T21:52:46Z

internal/ingress/annotations/authtls/main.go

+		annotationAuthTLSPassCertToUpstreamHeader: {
+			Validator:     parser.ValidateNull,
+			Scope:         parser.AnnotationScopeLocation,
+			Risk:          parser.AnnotationRiskLow,


I don't think this is Low, as you are allowing users to:

Add arbitrary string

Change the name of a security header

Sure, I don't know the implications of the risk levels. What do you recommend?

IMO we can set it to high level

github-actions · 2023-10-21T01:48:17Z

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

tuxillo · 2023-10-21T01:51:05Z

Yes please, don't close it :)

rikatz · 2023-10-21T02:13:50Z

It wont :) I just didn't had time to reach it, maybe on weekend (no promises, but will try!)

rikatz · 2023-10-21T02:14:59Z

@tuxillo I cant remember if we have an e2e test for authttls, but if we do do you mind adding a case for this annotation? Thanks!

k8s-ci-robot · 2024-07-02T03:13:10Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Allow specifying the name of the header for forwarding client certifi…

affd873

…cates

k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 1, 2023

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 1, 2023

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 1, 2023

k8s-ci-robot requested review from puerco and strongjz September 1, 2023 18:29

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 1, 2023

rikatz requested changes Sep 5, 2023

View reviewed changes

github-actions bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 21, 2023

github-actions bot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 23, 2023

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow specifying the name of the header for forwarding client certificates #10359

Allow specifying the name of the header for forwarding client certificates #10359

tuxillo commented Sep 1, 2023

linux-foundation-easycla bot commented Sep 1, 2023 •

edited

Loading

netlify bot commented Sep 1, 2023 •

edited

Loading

k8s-ci-robot commented Sep 1, 2023

k8s-ci-robot commented Sep 1, 2023

k8s-ci-robot commented Sep 1, 2023

k8s-ci-robot commented Sep 1, 2023

rikatz Sep 5, 2023

tuxillo Sep 5, 2023

rikatz Sep 5, 2023

tuxillo Sep 5, 2023

tao12345666333 Oct 21, 2023

github-actions bot commented Oct 21, 2023

tuxillo commented Oct 21, 2023

rikatz commented Oct 21, 2023

rikatz commented Oct 21, 2023

k8s-ci-robot commented Jul 2, 2024

Allow specifying the name of the header for forwarding client certificates #10359

Are you sure you want to change the base?

Allow specifying the name of the header for forwarding client certificates #10359

Conversation

tuxillo commented Sep 1, 2023

What this PR does / why we need it:

Types of changes

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

linux-foundation-easycla bot commented Sep 1, 2023 • edited Loading

netlify bot commented Sep 1, 2023 • edited Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

k8s-ci-robot commented Sep 1, 2023

k8s-ci-robot commented Sep 1, 2023

k8s-ci-robot commented Sep 1, 2023

k8s-ci-robot commented Sep 1, 2023

rikatz Sep 5, 2023

Choose a reason for hiding this comment

tuxillo Sep 5, 2023

Choose a reason for hiding this comment

rikatz Sep 5, 2023

Choose a reason for hiding this comment

tuxillo Sep 5, 2023

Choose a reason for hiding this comment

tao12345666333 Oct 21, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 21, 2023

tuxillo commented Oct 21, 2023

rikatz commented Oct 21, 2023

rikatz commented Oct 21, 2023

k8s-ci-robot commented Jul 2, 2024

linux-foundation-easycla bot commented Sep 1, 2023 •

edited

Loading

netlify bot commented Sep 1, 2023 •

edited

Loading