-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop NET_BIND_SERVICE for port binding #10004
Conversation
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @jkroepke. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR might be a bit too aggressive, since It contains a breaking changes. An alternative solution would be:
The ingess-nginx helm chart would handle this with an additional toggle. |
f8e8498
to
aea92c1
Compare
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
❌ Deploy Preview for kubernetes-ingress-nginx failed.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jkroepke The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
See #10002 .
Kubernetes 1.22 consider
net.ipv4.ip_unprivileged_port_start
as safe sysctl. This allows us to bind applications like ingress-nginx on port < 1024 without using theNET_BIND_SERVICE
capability. This may resolve some issue issues around debugging capability and using the sysctl may a clean alternative.Looking to the support matrix, Kubernetes 1.23 is the minimum supported version which fits the Kubernetes minimum requirements.
The sysctl
net.ipv4.ip_unprivileged_port_start
is compatible with PSA baseline and restricted.make image
implements a toggle for setting capabilities on that image.make image SETCAP=true
would result into an image with capabilities as it known.Types of changes
Which issue/s this PR fixes
fixes #10002
How Has This Been Tested?
Checklist: