Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop NET_BIND_SERVICE for port binding #10004

Closed
wants to merge 2 commits into from

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented May 29, 2023

What this PR does / why we need it:

See #10002 .

Kubernetes 1.22 consider net.ipv4.ip_unprivileged_port_start as safe sysctl. This allows us to bind applications like ingress-nginx on port < 1024 without using the NET_BIND_SERVICE capability. This may resolve some issue issues around debugging capability and using the sysctl may a clean alternative.

Looking to the support matrix, Kubernetes 1.23 is the minimum supported version which fits the Kubernetes minimum requirements.

The sysctl net.ipv4.ip_unprivileged_port_start is compatible with PSA baseline and restricted.

make image implements a toggle for setting capabilities on that image. make image SETCAP=true would result into an image with capabilities as it known.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

fixes #10002

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 29, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/docs labels May 29, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @jkroepke. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority area/helm Issues or PRs related to helm charts size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 29, 2023
@jkroepke jkroepke changed the title Remove NET_BIND_SERVICE for port binding Drop NET_BIND_SERVICE for port binding May 29, 2023
@jkroepke
Copy link
Contributor Author

This PR might be a bit too aggressive, since It contains a breaking changes. An alternative solution would be:

  • pushing a separate image with an suffix like -nocap
  • having the ingress-nginx. dump-init and nginx binary twice inside the image. On binary set have the capabilities while the other have the suffix -nocap without any capabilities.

The ingess-nginx helm chart would handle this with an additional toggle.

@jkroepke jkroepke force-pushed the remove-cap branch 3 times, most recently from f8e8498 to aea92c1 Compare May 29, 2023 11:17
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for kubernetes-ingress-nginx failed.

Name Link
🔨 Latest commit ac20c1f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/6499eea7e7d0b3000893ae3e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jkroepke
Once this PR has been reviewed and has the lgtm label, please assign tao12345666333 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkroepke jkroepke closed this Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide binaries without CAP_NET_BIND_SERVICE
2 participants