Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Nginx and Alpine version in legacy branch #7697

Closed
iamNoah1 opened this issue Sep 25, 2021 · 7 comments
Closed

Correct Nginx and Alpine version in legacy branch #7697

iamNoah1 opened this issue Sep 25, 2021 · 7 comments
Assignees
@jrushank
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@iamNoah1
Copy link
Contributor

iamNoah1 commented Sep 25, 2021 •
edited
Loading

We are on Nginx version 1.19 and alpine 3.14 on main and legacy branch. Unfortunately the code of legacy branch does not reflect the correct version. In order to prevent confusion and also to be sure that for eventually future versions based on legacy branch the images have correct versions of nginx and alpine, we need to adjust the code of legacy branch.

Have a look at these commits on main:

c6bc987#diff-78fbab3655980c4b1ba1cb27363d5eebcde239453bf026b9c4ec48977f057a57

cb8ebcb

My first guess is, that those are the changes need to be implemented on legacy branch as well (maybe cherry-pick).
Anything else we need to know:

/kind cleanup
/triage accepted
/priority important-soon
@iamNoah1 iamNoah1 added the kind/bug Categorizes issue or PR as related to a bug. label Sep 25, 2021
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Sep 25, 2021
@iamNoah1
Copy link
Contributor Author

/remove-kind bug

@k8s-ci-robot k8s-ci-robot removed the kind/bug Categorizes issue or PR as related to a bug. label Sep 25, 2021
@jrushank
Copy link

jrushank commented Oct 1, 2021

/assign

@tao12345666333
Copy link
Member

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@tao12345666333:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 1, 2021
@stevemcquaid
Copy link

I think #7736 fixes this issues

@stevemcquaid stevemcquaid mentioned this issue Nov 3, 2021
Merged
9 tasks
@iamNoah1
Copy link
Contributor Author

iamNoah1 commented Nov 4, 2021

@stevemcquaid jep

/close

@k8s-ci-robot
Copy link
Contributor

@iamNoah1: Closing this issue.

In response to this:

@stevemcquaid jep

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrushank jrushank

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@stevemcquaid @tao12345666333 @iamNoah1 @k8s-ci-robot @jrushank