IngressClass annotation support via IngressClassParams

[stevehipwell]

The ingress-nginx controller should support setting the annotations once for an IngressClass like the aws-load-balancer-controller has implemented. This could then be extended and improved to support named parameters if there was the desire.

Until this is completed ingressClassResource.parameters should be removed from the chart as this should be a reference to an instance of a CRD which would be where the parameters are set and the chart would create this and reference it from the IngressClass.

/kind feature

[k8s-ci-robot]

@stevehipwell: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dnutels]

I wonder how this proposal connects to Ingress parameters in spec.

[stevehipwell]

@dnutels this request is based on the spec. You've linked to a concept doc, which is based the spec I linked in the initial issue.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[stevehipwell]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[stevehipwell]

/remove-lifecycle stale

[longwuyuan]

This is resolved in release v1.1.2 of the ingress-nginx controller

/close