IngressClass annotation support via IngressClassParams

[stevehipwell]

The ingress-nginx controller should support setting the annotations once for an IngressClass like the aws-load-balancer-controller has implemented. This could then be extended and improved to support named parameters if there was the desire.

Until this is completed ingressClassResource.parameters should be removed from the chart as this should be a reference to an instance of a CRD which would be where the parameters are set and the chart would create this and reference it from the IngressClass.

/kind feature

[k8s-ci-robot]

@stevehipwell: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dnutels]

I wonder how this proposal connects to Ingress parameters in spec.

[stevehipwell]

@dnutels this request is based on the spec. You've linked to a concept doc, which is based the spec I linked in the initial issue.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[stevehipwell]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[stevehipwell]

/remove-lifecycle stale

[longwuyuan]

This is resolved in release v1.1.2 of the ingress-nginx controller

/close

[k8s-ci-robot]

@longwuyuan: Closing this issue.

In response to this:

This is resolved in release v1.1.2 of the ingress-nginx controller

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevehipwell]

@longwuyuan I can't see mention of this in the release notes or in the documentation? Could you point me at the right place to evaluate the changes?

[longwuyuan]

Maybe it should be more explicit in more places. But most people would not miss it in the Changeling https://github.com/kubernetes/ingress-nginx/blob/main/Changelog.md <https://github.com/kubernetes/ingress-nginx/blob/main/Changelog.md> Thanks, ; Long Wu Yuan

…

On 21-Mar-2022, at 3:04 PM, Steve Hipwell ***@***.***> wrote: @longwuyuan <https://github.com/longwuyuan> I can't see mention of this in the release notes or in the documentation? Could you point me at the right place to evaluate the changes? — Reply to this email directly, view it on GitHub <#7570 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWQV55XVSNR225Z6J7TVBA7DNANCNFSM5DD3G46Q>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.

[stevehipwell]

@longwuyuan firstly that PR isn't on the release page so it's quite easily missed, secondly it isn't related to this issue at all. This issue is about IngressClassParams and the use of them to carry the information that is currently carried in ingress controller specific annotations on the ingress object

Please could you re-open this issue.

[longwuyuan]

/reopen

[k8s-ci-robot]

@longwuyuan: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

Sorry, re-opened. If there can be some detailed elaborate description, maybe someone can set priority on this, after comparing with the aws-load-balancer-controller. Although I fail to see any sort of comparison between a ingress-controller and a load-balancer-controller, to begin with.

[stevehipwell]

@longwuyuan this issue is specifically about moving the Ingress Nginx custom annotations, which are scoped to the IngressClass, into a strongly typed IngressClassParams resource. Being strongly typed would make it both easier to create and process the parameters. Being one to one with an Ingress Class makes it clearer what is set rather than processing all ingresses and merging the annotations.

There is a secondary concern, which might have been addressed already, in that the Helm chart appeared to setup IngressClassParams but there isn't an Ingress Nginx type defined and it was syntactically incorrect (second paragraph in issue).

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[stevehipwell]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[stevehipwell]

/remove-lifecycle rotten