Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to go v1.17 #7520

Closed
rikatz opened this issue Aug 21, 2021 · 12 comments
Closed

Migrate to go v1.17 #7520

rikatz opened this issue Aug 21, 2021 · 12 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Milestone

Comments

@rikatz
Copy link
Contributor

rikatz commented Aug 21, 2021

Due to some vulnerabilities in go v1.16 we should migrate code to go v1.17

It is probably easy, but by the same time annoying to do:

  • Migrate go.mod
  • Migrate all the image runner files
  • Release a new e2e test runner image
  • Promote the image
  • Change in test-infra
  • Make a new release with go v1.17
  • Promote the release
@rikatz rikatz added the kind/bug Categorizes issue or PR as related to a bug. label Aug 21, 2021
@rikatz rikatz added this to the v1.0.0 milestone Aug 21, 2021
@k8s-ci-robot
Copy link
Contributor

@rikatz: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Aug 21, 2021
@swiftslee
Copy link
Contributor

I think we also need to upgrade github ci workflow to 1.17.

@tao12345666333
Copy link
Member

/help
/good-first

@k8s-ci-robot
Copy link
Contributor

@tao12345666333:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/good-first

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 21, 2021
@tao12345666333
Copy link
Member

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@tao12345666333:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Aug 21, 2021
@tao12345666333
Copy link
Member

Should we make this for only v1 or both v0.x and v1?

@longwuyuan
Copy link
Contributor

oh, I just that he image runner is explicit in K8s version

--build-arg K8S_RELEASE=v1.21.3 

@rikatz
Copy link
Contributor Author

rikatz commented Aug 22, 2021

@yuswift promoted the images.

Now your PR should be (all in one):

  • Change the go.mod
  • Change ci.yaml
  • Change all the test-runner references to point to k8s.gcr.io/ingress-nginx/e2e-test-runner:v20210822-g5e5faa24d@sha256:55c568d9e35e15d94b3ab41fe549b8ee4cd910cc3e031ddcccd06256755c5d89

Let me know when we can merge this :)

@swiftslee
Copy link
Contributor

@yuswift promoted the images.

Now your PR should be (all in one):

  • Change the go.mod
  • Change ci.yaml
  • Change all the test-runner references to point to k8s.gcr.io/ingress-nginx/e2e-test-runner:v20210822-g5e5faa24d@sha256:55c568d9e35e15d94b3ab41fe549b8ee4cd910cc3e031ddcccd06256755c5d89

Let me know when we can merge this :)

Thanks for your suggestion. I've committed them in #7521

@rikatz
Copy link
Contributor Author

rikatz commented Aug 23, 2021

@yuswift please cherry pick your PR to legacy branch!

Thanks!

@rikatz
Copy link
Contributor Author

rikatz commented Aug 24, 2021

/close

@rikatz rikatz closed this as completed Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

5 participants