-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve e2e tests checking if backends are properly working #7407
Comments
@rikatz: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rikatz: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please leave this issue for first time contributors :) Also, the above is an example, we need to check what tests lacks some backend testing and add into them |
sure. Which file? I want to separate one file per new contributor :) |
I would like to work on it, I am still learning the basics with daily sessions with @longwuyuan, I would like to improve tests for this |
Added names to the description. Will later check more tests needing to be evolved |
gRPC test should be broken because we removed the old gRPC app.
Thanks,
; Long
…On Mon, 2 Aug, 2021, 10:37 PM Ricardo Katz, ***@***.***> wrote:
Added names to the description.
Will later check more tests needing to be evolved
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7407 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGZVWTVUH56RX2FBWDUR7TT23GD3ANCNFSM5BHD3LKQ>
.
|
/reopen |
@rikatz: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Some e2e tests checks if the nginx generated template contains the expected string, but does not properly tests if it's really working.
Some examples:
As a good practice, we should verify not only if the template was generated correctly, but if it is working as desired.
A good example is available in
ingress-nginx/test/e2e/settings/ingress_class.go
Lines 289 to 293 in b809f81
to see if this is working as desired.
/good-first-issue
/area test
/triage accepted
/priority backlog
/kind cleanup
The text was updated successfully, but these errors were encountered: