Improve e2e tests checking if backends are properly working

[rikatz]

Some e2e tests checks if the nginx generated template contains the expected string, but does not properly tests if it's really working.

Some examples:

• https://github.com/kubernetes/ingress-nginx/blob/main/test/e2e/annotations/backendprotocol.go @ritwizsinha
• https://github.com/kubernetes/ingress-nginx/blob/main/test/e2e/annotations/disableaccesslog.go @yashikabadaya
• https://github.com/kubernetes/ingress-nginx/blob/main/test/e2e/annotations/clientbodybuffersize.go @gdsoumya Added checks to verify backend works with the given configs in e2e tests for client-body-buffer-size #7415
• https://github.com/kubernetes/ingress-nginx/blob/main/test/e2e/annotations/sslciphers.go @bhumijgupta

As a good practice, we should verify not only if the template was generated correctly, but if it is working as desired.

A good example is available in

ingress-nginx/test/e2e/settings/ingress_class.go

Lines 289 to 293 in b809f81

	f.HTTPTestClient().
	GET("/").
	WithHeader("Host", host).
	Expect().
	Status(http.StatusOK)

to see if this is working as desired.

/good-first-issue
/area test
/triage accepted
/priority backlog
/kind cleanup

[k8s-ci-robot]

@rikatz:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Some e2e tests checks if the nginx generated template contains the expected string, but does not properly tests if it's really working.

For example:

https://github.com/kubernetes/ingress-nginx/blob/main/test/e2e/annotations/backendprotocol.go

As a good practice, we should verify not only if the template was generated correctly, but if it is working as desired.

A good example is available in

ingress-nginx/test/e2e/settings/ingress_class.go

Lines 313 to 317 in b809f81

	f.HTTPTestClient().
	GET("/").
	WithHeader("Host", host).
	Expect().
	Status(http.StatusNotFound)

We should always test with:

  f.HTTPTestClient().
  		GET("/").
  		WithHeader("Host", host).
  		Expect().
  		Status(http.StatusOK)

to see if this is working as desired.

/good-first-issue
/area test
/triage accepted
/priority backlog
/kind cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@rikatz: The label(s) area/test cannot be applied, because the repository doesn't have them.

In response to this:

Some e2e tests checks if the nginx generated template contains the expected string, but does not properly tests if it's really working.

For example:

https://github.com/kubernetes/ingress-nginx/blob/main/test/e2e/annotations/backendprotocol.go

As a good practice, we should verify not only if the template was generated correctly, but if it is working as desired.

A good example is available in

ingress-nginx/test/e2e/settings/ingress_class.go

Lines 313 to 317 in b809f81

	f.HTTPTestClient().
	GET("/").
	WithHeader("Host", host).
	Expect().
	Status(http.StatusNotFound)

We should always test with:

  f.HTTPTestClient().
  		GET("/").
  		WithHeader("Host", host).
  		Expect().
  		Status(http.StatusOK)

to see if this is working as desired.

/good-first-issue
/area test
/triage accepted
/priority backlog
/kind cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rikatz]

Please leave this issue for first time contributors :)

Also, the above is an example, we need to check what tests lacks some backend testing and add into them

[rikatz]

sure. Which file? I want to separate one file per new contributor :)

[ritwizsinha]

I would like to work on it, I am still learning the basics with daily sessions with @longwuyuan, I would like to improve tests for this
file https://github.com/kubernetes/ingress-nginx/blob/main/test/e2e/annotations/backendprotocol.go

[gdsoumya]

@rikatz would like work on https://github.com/kubernetes/ingress-nginx/blob/main/test/e2e/annotations/clientbodybuffersize.go

[yashikabadaya]

I'd like to take up https://github.com/kubernetes/ingress-nginx/blob/main/test/e2e/annotations/disableaccesslog.go.

[bhumijgupta]

I'd like to take up https://github.com/kubernetes/ingress-nginx/blob/main/test/e2e/annotations/sslciphers.go

[rikatz]

Added names to the description.

Will later check more tests needing to be evolved

[longwuyuan]

gRPC test should be broken because we removed the old gRPC app. Thanks, ; Long

…

On Mon, 2 Aug, 2021, 10:37 PM Ricardo Katz, ***@***.***> wrote: Added names to the description. Will later check more tests needing to be evolved — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7407 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWTVUH56RX2FBWDUR7TT23GD3ANCNFSM5BHD3LKQ> .

[rikatz]

/reopen

[k8s-ci-robot]

@rikatz: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.