Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow config to disable geoip #2179

Closed
bputt opened this issue Mar 7, 2018 · 0 comments · Fixed by #2202
Closed

Allow config to disable geoip #2179

bputt opened this issue Mar 7, 2018 · 0 comments · Fixed by #2202
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@bputt
Copy link

bputt commented Mar 7, 2018

Is this a BUG REPORT or FEATURE REQUEST? (choose one): Feature
NGINX Ingress controller version: 0.11.0
Kubernetes version (use kubectl version): 1.9.2

In an offline environment, it'd be great to disable the geoip feature.

In the nginx.tmpl, it'd be great if you'd add something like the following:

{{ if $cfg.UseGeoIPTagging }}
geoip_country       /etc/nginx/geoip/GeoIP.dat;
geoip_city          /etc/nginx/geoip/GeoLiteCity.dat;
geoip_org           /etc/nginx/geoip/GeoIPASNum.dat;
geoip_proxy_recursive on;
{{ end }}

For backwards compatibility, UseGeoIPTagging could default to true

@aledbf aledbf added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 10, 2018
oilbeater added a commit to oilbeater/ingress-nginx that referenced this issue Mar 18, 2018
For a offline or private cloud environment, geoip is not needed.
Implementing kubernetes#2179
aledbf pushed a commit that referenced this issue Mar 18, 2018
For a offline or private cloud environment, geoip is not needed.
Implementing #2179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants