Bug: Formatting issue with load_module directives

[dcherniv]

NGINX Ingress controller version:
0.11.0

Kubernetes version (use kubectl version):
1.9.2

Environment:
GCP
container OS:
4.4.86+ #1 SMP Thu Dec 7 20:11:11 PST 2017 x86_64 GNU/Linux

What happened:
Upon updating the controller from 0.10.2 to 0.11.0, started seeing the below errors:

-------------------------------------------------------------------------------                                                                                                                
W0223 14:12:11.809571       7 queue.go:113] requeuing , err                                                                                                                                    
-------------------------------------------------------------------------------                                                                                                                
Error: exit status 1                                                                                                                                                                           
2018/02/23 14:12:11 [emerg] 1550#1550: unknown directive "load_module/etc/nginx/modules/ngx_http_opentracing_module.so" in /tmp/nginx-cfg821408788:2                                           
nginx: [emerg] unknown directive "load_module/etc/nginx/modules/ngx_http_opentracing_module.so" in /tmp/nginx-cfg821408788:2                                                                   
nginx: configuration file /tmp/nginx-cfg821408788 test failed                                                                                                                                  
                                                                                                                                                                                               
-------------------------------------------------------------------------------       

Looking at the /tmp/nginx config file i saw that the load_module directives were all mashed together on a single line with no spaces.

What you expected to happen:
opentracing enabled and zipkin working.

How to reproduce it (as minimally and precisely as possible):
Install 0.11.0 controller and add the following to configmap:

enable-opentracing: "true"
zipkin-collector-host: dev-zipkin-service

Anything else we need to know:
none.

[Monnoroch]

I'm having the same exact problem too both on 0.11.0 and 0.10.0. I'm pretty sure there should be a space after load_module in here: https://github.com/kubernetes/ingress-nginx/blob/master/internal/ingress/controller/template/template.go#L732.

[Monnoroch]

Yep, just tested it, adding a space fixes the problem.

[aledbf]

@Monnoroch can you open a PR to fix this?
Thanks

[dcherniv]

In #2136 can a newline be added if it's in fact missing?
Another thing that i saw that i forgot to mention is the load_module lines for opentracing were in fact on the same line separated by ;