Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undocumented annotation #1950

Closed
Stono opened this issue Jan 23, 2018 · 3 comments
Closed

Undocumented annotation #1950

Stono opened this issue Jan 23, 2018 · 3 comments
Labels
area/docs help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@Stono
Copy link
Contributor

Stono commented Jan 23, 2018

Hey,
I've just come across an annotation that saved my ass, and found it was undocumented.
Might be worth adding?

ingress-nginx/internal/ingress/annotations/upstreamvhost/main.go

Line 39 in cdbb9bd

return parser.GetStringAnnotation("upstream-vhost", ing)

Ta
Karl
@aledbf aledbf added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. area/docs labels Jan 23, 2018
@aledbf
Copy link
Member

aledbf commented Jan 23, 2018

Might be worth adding?

Yes

@Stono
Copy link
Contributor Author

Stono commented Jan 23, 2018

I'll do a PR for it shortly

@Stono Stono mentioned this issue Jan 23, 2018
Merged
aledbf pushed a commit that referenced this issue Jan 23, 2018
@Stono @aledbf
Added annotation for upstream-vhost (#1953)
8ee6941 
#1950
@aledbf
Copy link
Member

aledbf commented Jan 23, 2018

Closing. Fixed in 1953

@aledbf aledbf closed this as completed Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/docs help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aledbf @Stono