Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableLeaderElection code changes missing in nginx-ingress-controller-v1.10.4 #11900

Closed
izanami-01 opened this issue Aug 29, 2024 · 4 comments
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@izanami-01
Copy link

What happened:

I was trying to upgrade ingress-nginx from 1.10.0 to 1.10.4, later found that disableLeaderElection code changes introduced in controller-v1.10.1 as part of #11064 is missing.

What you expected to happen:
Changes - https://github.com/kubernetes/ingress-nginx/pull/11064/files#diff-86a6b54df1345b10b1d2385b6a236500d34a82625045de56a08d4f711b505b88 should be present in controller-v1.10.4

@izanami-01 izanami-01 added the kind/bug Categorizes issue or PR as related to a bug. label Aug 29, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 29, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@strongjz
Copy link
Member

Youll need to upgrade to 1.11 for this feature.

/close

@k8s-ci-robot
Copy link
Contributor

@strongjz: Closing this issue.

In response to this:

Youll need to upgrade to 1.11 for this feature.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@strongjz
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

3 participants