Skip to content

Fix non-master branches and tags - #19

Merged
thockin merged 1 commit into
kubernetes:masterfrom
thockin:master
Oct 28, 2016
Merged

Fix non-master branches and tags#19
thockin merged 1 commit into
kubernetes:masterfrom
thockin:master

Conversation

@thockin

@thockin thockin commented Oct 28, 2016

Copy link
Copy Markdown
Member

This plus the test should ensure no regressions. Git makes it tricky to do
some things on a remote that you would think to do on a local repo.
ls-remote gives me the info I need with only one test for "HEAD" vs anything
else.

Fixes #14

@stp-ip
@ursuad


This change is Reviewable

This plus the test should ensure no regressions.  Git makes it tricky to do
some things on a remote that you would think to do on a local repo.
`ls-remote` gives me the info I need with only one test for "HEAD" vs anything
else.
@stp-ip

stp-ip commented Oct 28, 2016

Copy link
Copy Markdown
Member

From the code side I would say LGTM, but let me check the use-case against the latest code.

@stp-ip

stp-ip commented Oct 28, 2016

Copy link
Copy Markdown
Member

All tests in my dev cluster work out.

LGTM

@thockin thockin mentioned this pull request Oct 28, 2016
@thockin
thockin merged commit 1b8d34b into kubernetes:master Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants