Skip to content

AI Example model serving tensorflow #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 4, 2025
Merged

AI Example model serving tensorflow #563

merged 14 commits into from
Jun 4, 2025

Conversation

jayeshmahajan
Copy link
Contributor

@jayeshmahajan jayeshmahajan commented May 27, 2025 •
edited
Loading

Here is a complete example for serving a TensorFlow model on Kubernetes using TensorFlow Serving. This setup includes deployment, service, and optional ingress for external access.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 27, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @jayeshmahajan!

It looks like this is your first PR to kubernetes/examples 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/examples has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from kow3ns and soltysh May 27, 2025 01:37
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 27, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2025
@jayeshmahajan jayeshmahajan marked this pull request as ready for review May 27, 2025 01:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2025
@jayeshmahajan jayeshmahajan changed the title Create AI Example model serving tensorflow AI Example model serving tensorflow May 27, 2025
@jayeshmahajan jayeshmahajan mentioned this pull request May 27, 2025
Closed
11 tasks
@soltysh
Copy link
Contributor

soltysh commented May 27, 2025

/assign @janetkuo
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 27, 2025
janetkuo
janetkuo reviewed May 27, 2025
View reviewed changes
janetkuo
janetkuo reviewed May 28, 2025
View reviewed changes
janetkuo
janetkuo reviewed Jun 2, 2025
View reviewed changes
Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few final nits; lgtm otherwise

ai/model-serving-tensorflow/ingress.yaml Outdated
nginx.ingress.kubernetes.io/rewrite-target: /$2
spec:
rules:
- host: tf.example.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the host key here? Can we remove it or make it optional so that DNS isn't required for this example? If removing / making this optional, change <ingress-host> in README to <ingress-host-or-ip> as well.

janetkuo
janetkuo reviewed Jun 2, 2025
View reviewed changes
janetkuo
janetkuo approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, jayeshmahajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0598f07 into kubernetes:master Jun 4, 2025
2 checks passed
@jayeshmahajan jayeshmahajan deleted the patch-1 branch June 4, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@janetkuo janetkuo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jayeshmahajan @k8s-ci-robot @soltysh @janetkuo