add release checklist, grad criteria, upgrade strategy to sidecar kep #918
Conversation
k8s-ci-robot
added
sig/apps
|
Hi @Joseph-Irving. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
Joseph-Irving
force-pushed
the
sidecar_design_details
branch
from
845140d
to
11db464
Compare
| ### Graduation Criteria | ||
| #### Alpha -> Beta Graduation | ||
| * Addressed feedback from Alpha testers | ||
| * Thorough E2E and Unit testing in place |
There was a problem hiding this comment.
I suggest adding:
- The beta API either supports the important use cases discovered during alpha testing, or has room for further enhancements that would support them.
| * Thorough E2E and Unit testing in place | ||
|
|
||
| #### Beta -> GA Graduation | ||
| * Sufficient number of end users are using the feature |
There was a problem hiding this comment.
Plus:
- We're confident that no further API changes will be needed to achieve the goals of the KEP.
keps/sig-apps/sidecarcontainers.md
Outdated
|
|
||
| #### Beta -> GA Graduation | ||
| * Sufficient number of end users are using the feature | ||
| * No significant bugs found for 2 beta releases |
There was a problem hiding this comment.
We generally assume that the alpha and beta periods are sufficient to discover the significant blocking bugs. We then say the GA criterion is that all known blocking bugs must be fixed. We don't usually add another "waiting period" after all known bugs are fixed, since that would make features very slow to progress.
There was a problem hiding this comment.
Ok, sounds reasonable, I saw this kind of thing in some other KEPs so I wasn't sure if it was convention to wait a few releases.
keps/sig-apps/sidecarcontainers.md
Outdated
| When upgrading no changes should be needed to maintain existing behaviour as all of this behaviour is optional and disabled by default. | ||
| To activate the feature they will need to enable the feature gate and mark their containers as sidecars in the container spec. | ||
|
|
||
| When downgrading users will need to remove the sidecar field from their container specs as the Apiserver will not recognise the field. |
There was a problem hiding this comment.
If I recall correctly, I think the apiserver will silently drop unknown fields. On the other hand, by default kubectl will try to block sending of unknown fields on the client side.
There was a problem hiding this comment.
Yeah I was confusing this with Kubectl, the api will just drop it. I'll rephrase this to be about kubectl.
Joseph-Irving
force-pushed
the
sidecar_design_details
branch
from
11db464
to
5788252
Compare
Joseph-Irving
force-pushed
the
sidecar_design_details
branch
from
5788252
to
9a1a865
Compare
|
Thanks for the comments @enisoc, I've updated the PR to reflect your feedback |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enisoc, Joseph-Irving, kow3ns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
I've updated this KEP #753 to match the new template format such as adding the release signoff checklist.
Added my initial thoughts on Graduation criteria, Upgrade/Downgrade strategy and Version Skew. I'll add the test plan in a separate PR as that could do with its own discussion.
/sig apps
/sig node
/assign @enisoc @kow3ns