cleaning up KEP-removing-in-tree-providers #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
kind/kep
andrewsykim
changed the title
k8s-ci-robot
added
the
size/M
cheftako
reviewed
Feb 15, 2019
| @@ -76,27 +76,29 @@ document, and merits discussion in a broader forum and input from SIG-Architectu | |||
| considered to be safe to be vendored outside of the K8s/K8s repo and which should eventually be fully separated from | |||
| the K8s/K8s repo. Contents of Staging are prevented from depending on code in K8s/K8s which are not in Staging. | |||
| Controlled by [publishing kubernetes-rules-configmap](https://github.com/kubernetes/publishing-bot/blob/master/configs/kubernetes-rules-configmap.yaml) | |||
| - **In-tree**: code that lives in the core Kubernetes repository `k8s.io/kubernetes`. | |||
There was a problem hiding this comment.
It might make more sense if we specify it as 'https://github.com/kubernetes/kubernetes'
andrewsykim
force-pushed
the
remove-cloud-provider-kep-updates
branch
from
b83e0c4
to
5831923
Compare
|
/lgtm (please cancel hold when you feel this is ready) |
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing some KEP clean up for cloud provider extraction efforts.
/assign @cheftako @dims @jagosan @hogepodge @d-nishi @mcrute