-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-5339: define extensions-based per-cluster plugin configuration #5643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
|
Hi @kahirokunn. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@corentone Hi ✋ |
corentone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! Just an array to change into a quote.
Thank you for syncing on #5559 too !
keps/sig-multicluster/5339-clusterprofile-plugin-credentials/README.md
Outdated
Show resolved
Hide resolved
keps/sig-multicluster/5339-clusterprofile-plugin-credentials/README.md
Outdated
Show resolved
Hide resolved
keps/sig-multicluster/5339-clusterprofile-plugin-credentials/README.md
Outdated
Show resolved
Hide resolved
keps/sig-multicluster/5339-clusterprofile-plugin-credentials/README.md
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: corentone, kahirokunn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…EADME.md Just an array to change into a quote Co-authored-by: Corentin Debains <corentone@users.noreply.github.com> Signed-off-by: kahirokunn <okinakahiro@gmail.com>
f3585ec to
96e8c78
Compare
|
@corentone Thank you for your review! I have merged all commit suggestions and integrated them into a single commit. 🙏 |
One-line PR description:
Define extensions-based per-cluster plugin configuration and pass-through to ExecCredential.Spec.Cluster.Config
Issue link:
sig-multicluster's ClusterProfile should have a way to support credentials issuance #5339
Other comments:
extensionobject through toExecCredential.Spec.Cluster.Configwhen presentclusterNamevia extensionsconfigsourced fromextensions[client.authentication.k8s.io/exec]:https://kubernetes.io/docs/reference/config-api/client-authentication.v1/#client-authentication-k8s-io-v1-Cluster
https://github.com/kubernetes-sigs/cluster-inventory-api/pull/21/files#diff-9079632b67f704fe47373dc3fc1cf49db8b421592a06ffb89d74d436a65faf2c