KEP-4817: fix metrics to use apiserver_request_total #5206
Merged
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
kind/kep
k8s-ci-robot
added
sig/node
Member
Author
|
/assign @aojea @johnbelamaric |
k8s-ci-robot
added
the
wg/device-management
pohly
reviewed
Mar 17, 2025
| metrics: | ||
| - resourceclaim_status_devices_update_attempts_total | ||
| - resourceclaim_status_devices_update_failures_total | ||
| - apiserver_request_total{group="resource.k8s.io", version="v1beta1", resource="resourceclaims", subresource="status"} |
Contributor
There was a problem hiding this comment.
Nit: line break at end of the file.
Otherwise it looks fine.
Member
|
/approve final LGTM for @pohly |
LionelJouin
force-pushed
the
kep-4817-update-metrics
branch
2 times, most recently
from
dc0997c to
a802199
Compare
Signed-off-by: Lionel Jouin <lionel.jouin@est.tech>
LionelJouin
force-pushed
the
kep-4817-update-metrics
branch
from
a802199 to
fc2184b
Compare
Member
|
/approve cc @mrunalp I usually like to get a real SIG node approval but this is just a simple update, hopefully you're ok with it |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, johnbelamaric, LionelJouin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes requested during the implementation of the metrics for KEP-4817
resourceclaim update status metrics kubernetes#130812 (comment)