Skip to content

Conversation

@cici37
Copy link
Contributor

@cici37 cici37 commented Mar 11, 2025

  • One-line PR description:
  • Issue link:
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Mar 11, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Scheduling Mar 11, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 11, 2025
@cici37
Copy link
Contributor Author

cici37 commented Mar 11, 2025

/assign @johnbelamaric

@johnbelamaric
Copy link
Member

/approve
/assign @thockin @dom4ha
/cc @pohly @mortent @klueska

@cici37, @thockin and I discussed this last week.

In the Composability in ResourceSlice APIs document, we agreed to move all of the new fields under Device in a new v1beta2 API. The simplest thing to do to enable a clean round tripping is to add all the fields to BasicDevice in v1beta1, then the v1beta2 is easy to implement. There is no benefit to introducing CompositeDevice at this time, and it makes round tripping very challenging.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2025
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

It affects the "Rollout, Upgrade and Rollback Planning", but as that's for beta there is no need to change anything right now.

@github-project-automation github-project-automation bot moved this from Needs Triage to Needs Approval in SIG Scheduling Mar 11, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cici37, johnbelamaric, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit efd94f0 into kubernetes:master Mar 11, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Needs Approval to Done in SIG Scheduling Mar 11, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 11, 2025
@cici37 cici37 deleted the draPD branch March 11, 2025 21:17
@johnbelamaric johnbelamaric mentioned this pull request Mar 12, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants