-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update the API design for PartitionableDevice #5195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cici37
commented
Mar 11, 2025
- One-line PR description:
- Issue link:
- Other comments:
|
/assign @johnbelamaric |
|
/approve @cici37, @thockin and I discussed this last week. In the Composability in ResourceSlice APIs document, we agreed to move all of the new fields under |
pohly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
It affects the "Rollout, Upgrade and Rollback Planning", but as that's for beta there is no need to change anything right now.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cici37, johnbelamaric, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |