Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP 2590: Graduate kubectl subresource to GA #5079

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

KEP 2590: Graduate kubectl subresource to GA #5079

wants to merge 2 commits into from
+103 −75

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Jan 23, 2025 •
edited
Loading

  • One-line PR description: Graduate kubectl subresource to GA

/assign @MadhavJivrajani @nikhita
for reviews

/assign @ardaguclu
for sig-cli approval

/assign @johnbelamaric
for prr approval

@MadhavJivrajani @soltysh
sig-cli: graduate kubectl subresource support to GA
bd97a39 
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jan 23, 2025
@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2025
@soltysh
Copy link
Contributor Author

soltysh commented Jan 23, 2025

/hold
so it doesn't merge accidentally before getting all of the approvals (initial authors, sig-cli and PRR)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2025
@soltysh soltysh mentioned this pull request Jan 23, 2025
Open
12 tasks
@soltysh soltysh force-pushed the kubectl_subresource branch from 1d48bc9 to af1bb82 Compare January 24, 2025 10:09
@ardaguclu
Copy link
Member

Thank you. These changes reflect the reality.

/lgtm
from sig-cli POV

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2025
@nikhita
Copy link
Member

nikhita commented Jan 28, 2025

@soltysh it looks like there may be one pending comment from the previous PR around an integration test - https://github.com/kubernetes/enhancements/pull/4468/files#r1480169620. Should we call it out here?

Other than that, lgtm.

@soltysh soltysh mentioned this pull request Jan 28, 2025
Merged
soltysh
soltysh commented Jan 28, 2025
View reviewed changes
keps/sig-cli/2590-kubectl-subresource/README.md Outdated

TODO:

- Add a test ensuring ALL scale sub-resources continue to support tables.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhita this is the test you've mentioned, and the PR for it is in kubernetes/kubernetes#129858

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this section, now that this PR merged.

@soltysh
KEP 2590: update document for stable promotion
67b794d 
Signed-off-by: Maciej Szulik <soltysh@gmail.com>
@soltysh soltysh force-pushed the kubectl_subresource branch from af1bb82 to 67b794d Compare January 28, 2025 18:12
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@mpuckett159 mpuckett159 Awaiting requested review from mpuckett159

Assignees

@johnbelamaric johnbelamaric

@ardaguclu ardaguclu

@MadhavJivrajani MadhavJivrajani

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG CLI
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@soltysh @k8s-ci-robot @ardaguclu @nikhita @johnbelamaric @MadhavJivrajani