Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4396 Fix beta stage description #4926

Merged
merged 1 commit into from
Oct 22, 2024
Merged

KEP-4396 Fix beta stage description #4926

merged 1 commit into from
Oct 22, 2024

Conversation

HirazawaUi
Copy link
Contributor

  • One-line PR description: Fixed incorrect description when promoting to beta stage
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Oct 20, 2024
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 20, 2024
@k8s-ci-robot k8s-ci-robot requested a review from mrunalp October 20, 2024 16:37
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 20, 2024
HirazawaUi
HirazawaUi commented Oct 20, 2024
View reviewed changes
keps/sig-node/4369-allow-special-characters-environment-variable/README.md
- [x] Metrics
- Metric name: run_podsandbox_errors_total
- [ ] Metrics
- Metric name:
Copy link
Contributor Author

@HirazawaUi HirazawaUi Oct 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this metric because we didn't affect the RunPodSandbox call; we only impacted the CreateContainer phase, which was an earlier mistake of mine. Or do we need to add a new metric at the CreateContainer phase, such as create_container_error? I'm not sure if we really need it. Please refer to the URL of the test project pointed out in the KEP. So far, I haven't found any scenarios where relaxed environment variable names cause container runtime errors.

@HirazawaUi
Copy link
Contributor Author

HirazawaUi commented Oct 20, 2024 •
edited
Loading

/cc @SergeyKanzhelev @jpbetz

Since the freeze for enhancements has passed, I am not sure if this PR will still be accepted. Should we merge this PR?

HirazawaUi
HirazawaUi commented Oct 20, 2024
View reviewed changes
keps/sig-node/4369-allow-special-characters-environment-variable/README.md
@@ -224,7 +224,9 @@ Yes.

### Rollout, Upgrade and Rollback Planning

When the feature gate is disabled, workloads that are already running will not be affected. If environment variables contain special characters, changes to fields other than the environment variables will not cause workloads to fail. However, if the environment variable fields are modified, they may fail to recreate Pods or ReplicaSets due to the Apiserver's validation logic, which could result in workload failures.
###### How can a rollout or rollback fail? Can it impact already running workloads?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted it to the previous description of #4805 (comment)

kannon92
kannon92 reviewed Oct 20, 2024
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the job you added for this?

@HirazawaUi
Copy link
Contributor Author

Could you add the job you added for this?

Added.

@kannon92
Copy link
Contributor

/lgtm
/assign @mrunalp @dchen1107 @SergeyKanzhelev

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@kannon92
Copy link
Contributor

/unassign @dchen1107 @mrunalp

SergeyKanzhelev
SergeyKanzhelev approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit c906d61 into kubernetes:master Oct 22, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@mrunalp mrunalp Awaiting requested review from mrunalp

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@kannon92 kannon92

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
6 participants
@HirazawaUi @kannon92 @k8s-ci-robot @SergeyKanzhelev @mrunalp @dchen1107