Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3545: graduate to GA #4882

Merged
merged 1 commit into from
Oct 9, 2024
Merged

KEP-3545: graduate to GA #4882

merged 1 commit into from
Oct 9, 2024

Conversation

PiotrProkop
Copy link
Contributor

  • One-line PR description: Graduate KEP-3545 Improved multi-numa alignment in Topology Manager to GA
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 30, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 30, 2024
@PiotrProkop
Copy link
Contributor Author

/assign @klueska

@PiotrProkop PiotrProkop force-pushed the multi-numa-stable branch 2 times, most recently from 41b9db3 to bb22abb Compare September 30, 2024 09:52
@PiotrProkop
Copy link
Contributor Author

/assign @johnbelamaric for PRR review

@PiotrProkop PiotrProkop mentioned this pull request Oct 3, 2024
Open
12 tasks
ffromani
ffromani reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass: additions LGTM, need to review the full text to check if it is still accurate for GA

keps/sig-node/3545-improved-multi-numa-alignment/README.md Outdated Show resolved Hide resolved
keps/sig-node/3545-improved-multi-numa-alignment/README.md Outdated Show resolved Hide resolved
keps/sig-node/3545-improved-multi-numa-alignment/README.md Show resolved Hide resolved
keps/sig-node/3545-improved-multi-numa-alignment/README.md Show resolved Hide resolved
keps/sig-node/3545-improved-multi-numa-alignment/README.md Show resolved Hide resolved
deads2k
deads2k requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@deads2k deads2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

keps/prod-readiness/sig-node/3545.yaml Outdated Show resolved Hide resolved
@deads2k
Copy link
Contributor

deads2k commented Oct 7, 2024

PRR looks good for stable

/approve

@PiotrProkop
KEP-3545: graduate to GA
230c534 
Signed-off-by: pprokop <pprokop@nvidia.com>
@PiotrProkop
Copy link
Contributor Author

@deads2k I've change the reviewer for stable release, can you re-approve?

mrunalp
mrunalp approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mrunalp, PiotrProkop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6292e2b into kubernetes:master Oct 9, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffromani ffromani ffromani left review comments

@deads2k deads2k deads2k requested changes

@mrunalp mrunalp mrunalp approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@mrunalp mrunalp

@klueska klueska

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
6 participants
@PiotrProkop @deads2k @k8s-ci-robot @mrunalp @ffromani @klueska