Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4033: bump to beta #4682

Merged
merged 1 commit into from
Jun 11, 2024
Merged

KEP-4033: bump to beta #4682

merged 1 commit into from
Jun 11, 2024

Conversation

haircommander
Copy link
Contributor

  • One-line PR description:
    bump KEP-4033 to beta
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2024
mrunalp
mrunalp approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2024
sftim
sftim reviewed Jun 3, 2024
View reviewed changes
keps/sig-node/4033-group-driver-detection-over-cri/kep.yaml Outdated

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.28"
beta: "v1.yy"
beta: "v1.30"
stable: "v1.zz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stable: "v1.zz"

keps/sig-node/4033-group-driver-detection-over-cri/kep.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

# The following PRR answers are required at beta release
metrics: []

If that's correct, consider updating the comment to clarify.

keps/sig-node/4033-group-driver-detection-over-cri/kep.yaml Outdated

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.28"
beta: "v1.yy"
beta: "v1.30"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.30? Is that right?

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2024
@haircommander
KEP-4033: bump to beta
8b740c6 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 4, 2024
@dipesh-rawat dipesh-rawat mentioned this pull request Jun 5, 2024
Open
9 tasks
@ffromani
Copy link
Contributor

ffromani commented Jun 5, 2024

LGTM (non binding because...)
do we need PRR updates for beta?

@haircommander
Copy link
Contributor Author

LGTM (non binding because...) do we need PRR updates for beta?

AFAICT it's all done already

@ffromani
Copy link
Contributor

ffromani commented Jun 5, 2024

/lgtm

LGTM (non binding because...) do we need PRR updates for beta?

AFAICT it's all done already

got it, thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2024
@johnbelamaric
Copy link
Member

/approve for PRR
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, johnbelamaric, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9c3a40a into kubernetes:master Jun 11, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@mrunalp mrunalp mrunalp approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@mrunalp mrunalp

@johnbelamaric johnbelamaric

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
6 participants
@haircommander @ffromani @johnbelamaric @k8s-ci-robot @mrunalp @sftim