-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-2000: Add note in KEP Proposal for shutdown -h now
systemd version compatibility
#4640
KEP-2000: Add note in KEP Proposal for shutdown -h now
systemd version compatibility
#4640
Conversation
Welcome @tuibeovince! |
Hi @tuibeovince. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cc to the KEP-2000 author @bobbypage |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, tuibeovince The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
One-line PR description:
Add note indicating that 'shutdown -h now` may not trigger GracefulNodeShutdown in the KEP-2000.
Issue link:
GracefulNodeShutdown does not trigger on nodes shutdown with
shutdown -h now
kubernetes#124039Other comments:
Having
shutdown -h now
listed as the first way of shutting down gives the false impression that this method is recommended. But in some environments, the GracefulNodeShutdown may not trigger withshutdown -h now